Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes limit/offset syntax error #1

Merged
merged 1 commit into from Nov 8, 2017
Merged

fixes limit/offset syntax error #1

merged 1 commit into from Nov 8, 2017

Conversation

conradkleinespel
Copy link
Contributor

@conradkleinespel conradkleinespel commented Nov 7, 2017

Hi @jacobbudin ! Thanks for this library, easy to use !

Just noticed that the LIMIT/OFFSET syntax was broken. LIMIT x, y in Mysql, does the same as LIMIT y OFFSET x. And also LIMIT x, y does not work with Sqlite or Postgres.

LIMIT x OFFSET y works in all 3 databases according to the docs. This is what this commit is about.

@jacobbudin
Copy link
Owner

@jacobbudin jacobbudin commented Nov 8, 2017

LGTM. Confirmed syntax in this document. Thanks, @conradkdotcom. I will publish a point release momentarily.

@jacobbudin jacobbudin merged commit d7e6b45 into jacobbudin:master Nov 8, 2017
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@conradkleinespel @jacobbudin